Closed Al-Azif closed 1 month ago
@Al-Azif Awesome! Was going to begin working on FW 8.00. Thank you so much for your contribution!
Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.
Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.
Sorry Azif but I also fixed some typo you had on the stage1 and stage2 and one bad offset as oxf0xf typo also... I didn't saw any issues doing a PR with the fixes.. credits are all yours!!!
Normally you'd commit to my branch and co-authoring is done like this https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors. I'm just mentioned in the PR title.
A strategic mistake I see here ðŸ«
Well this PR matches the repo now, just with some semblance of proper credit
Any reason why @kmeps4 opened up a new PR, without putting me as a co-author even, rather than just confirming this commit works? As now this PR is in conflict.
Dam lol
Untested, just happened to have 99% off the offsets from other stuff