TheOfficialFloW / VitaShell

Multi-functional file manager for PS Vita
GNU General Public License v3.0
1.38k stars 224 forks source link

Feature/bookmarks #487

Closed abertschi closed 5 years ago

abertschi commented 5 years ago

My new Vita has arrived so I finally manage to finish this PR.

This implements bookmarks and recent files #436. Three new menu entries are added (screenshot).

Bookmarks of files/folders can be created with New -> New Bookmark

2018-09-12-181041

VitaShell rocks <3

TheOfficialFloW commented 5 years ago

Thanks for your amazing contribution. I've got some small change requests:

Code:

Aesthetics:

Functionality:

Then I'm happy to merge :)

abertschi commented 5 years ago

When in recent files/show bookmarks, pressing O should always return back to normal browser.

Can you elaborate on this? When pressing O, the parent directory is browsed. In case a symlink is resolved, the parent directory is where the symlink was located.

I set the key shortcuts as follows:

The file extension is "lnk".

The recent directory is deleted every 14 days.

TheOfficialFloW commented 5 years ago

I still think we should not use the L trigger but the left arrow on digital pad for combos, otherwise you cannot exactly return to where you were before. I mean if you are at ux0:VitaShell/bookmarks or ux0:VitaShell/recent and press O, you should go back to where you were before. This does not happen when you switch from bookmarks to recent back and forth alot, then it will be hard to get out and return back to normal browser.

abertschi commented 5 years ago

I still think we should not use the L trigger but the left arrow on digital pad for combos, otherwise you cannot exactly return to where you were before.

You are right. I mistook the keys L and left. The shortcuts are now left + square/triangle.

I mean if you are at ux0:VitaShell/bookmarks or ux0:VitaShell/recent and press O, you should go back to where you were before. This does not happen when you switch from bookmarks to recent back and forth alot, then it will be hard to get out and return back to normal browser.

ok!