TheOld / vscode-fluent-ui

MIT License
112 stars 14 forks source link

Fluent UI: Enable v3.6.0 bulild 1.72.2 #43

Open DimitrisMilonopoulos opened 1 year ago

DimitrisMilonopoulos commented 1 year ago

image

Getting this error for all the commands and the commands on your package.json seem to be correctly registered.

DimitrisMilonopoulos commented 1 year ago

btw works ok 3.0.1

rojnwa commented 1 year ago

Works with 3.3.0. Starts breaking with 3.4.0

TheOld commented 1 year ago

Can you try out with the latest version (3.6.0)? There was indeed issues with 3.3 and 3.4 that were fixed.

rojnwa commented 1 year ago

3.6.0 does not work. 3.3.0 does actually work.

TheOld commented 1 year ago

Hey @DimitrisMilonopoulos and @rojnwa, can you try out the new version 3.8 please? It contains fixes for some issues that I believe were the ones blocking you.

rojnwa commented 1 year ago

@TheOld Sadly, it's still coming up. image

TheOld commented 1 year ago

Damn, that's odd.

What OS you're using there? I did test this out in a couple of different machines (Win 10/11 and MacOS) and it worked fine on all instances;

There's a couple of things we can check to try finding out why it isn't working for you.

  1. Can you get a screenshot of VSCode's console when you run the command? It should output more details regarding the error there.
  2. Also, could you check you have the workbench.html file on this path (or equivalent on your OS)? On Windows it would be C:\Users\{username}\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\code\electron-sandbox\workbench.
rojnwa commented 1 year ago

I'm using Arch Linux. I do have another machine running windows on which this works flawless. It's really odd that versions up until (including) 3.3.0 are working just fine. I didn't see any noticeable changes between 3.3.0 and 3.4.0 which could've caused or negatively impacted this.

dzgeorgy commented 1 year ago

Installed 3.3.0, enabled theme, updated to 3.8.0 and seems like everything is fine on macOS

SuperSayf commented 1 year ago

I'm using Arch Linux. I do have another machine running windows on which this works flawless. It's really odd that versions up until (including) 3.3.0 are working just fine. I didn't see any noticeable changes between 3.3.0 and 3.4.0 which could've caused or negatively impacted this.

How did you manage to run the Fluent UI enable command, I can't seem to get vs code running as admin on Zorin OS, and I keep getting an error that the files are Read-only

Blakeinstein commented 1 year ago

Trying to do this on a mac, but cant use the latest features because the commands refuse to work :(

rojnwa commented 1 year ago

Any updates on this? @TheOld

juzijun233 commented 1 year ago

Weird glitch. On macOS, neither 3.8.0/3.6.0 works, after using 3.3.0 it can be enabled, then update to 3.8.0, everything works. 3.8.0 can be used directly on Windows

TheOld commented 1 year ago

Hey folks,

I'll be looking at this (and other issues) in the coming weeks. I'll keep this thread updated with the progress as much as possible, so keep an eye on it.

OmidHaqi commented 5 months ago

download and replace this 4 file in /usr/share/code/resources/app/out/vs/code/electron-sandbox