Closed bakerbrandond closed 1 year ago
There's some weird stuff going on in sol, does it work if you change this line: https://github.com/TheOpenSpaceProgram/new-ospgl/blob/bdb9057c6d802004c71c864320b8c8b09845534f/dep/sol/sol.hpp#L2373C11-L2373C11 to
#include <limits>
I'll push the change for now. IIRC a newer version of sol fixed this, but updating sol may require some code changes to build so for now i'm simply going to push this fix.
No idea why it only fails only on some computers (including the CI!), probably some weird default behaviour.
I'll push the change for now. IIRC a newer version of sol fixed this, but updating sol may require some code changes to build so for now i'm simply going to push this fix.
No idea why it only fails only on some computers (including the CI!), probably some weird default behaviour.
Thanks, I'm able to compile the binary with gcc11 after the change... funny enough though I am still getting errors when trying to build with gcc10
❯ CC=/home/linuxbrew/.linuxbrew/bin/gcc-10 cmake --build . -- -j 4
...
[ 97%] Linking CXX executable ospgl
/usr/bin/ld: CMakeFiles/OSPGL.dir/dep/glad/glad.c.o: relocation R_X86_64_32S against `.data' can not be used when making a PIE object; recompile with -fPIE
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
gmake[2]: *** [CMakeFiles/OSPGL.dir/build.make:2571: ospgl] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:309: CMakeFiles/OSPGL.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2
I'm fine with closing the issue. Just giving you a heads up.
Those are some weird linker errors! I can only find references to the first when compiling assembly code, which glad
is definitely not! :thinking:
I have tried g++-11 too and it works fine, going to change the README to note that. The continous integration uses g++-9 so it's a wide array of compiler versions to try on if some of these weird problems show up!
I'm on linux, using linuxbrew I installed gcc@10 per the README, I am still unable to build the application