Closed Capital-Asterisk closed 1 year ago
Well that's an enormous diff.
I reviewed it as best i could and didn't see anything glaring. But no promises that i didn't overlook something.
if you rebase on master, everything in the CI should work except for the windows analyzer.
Ok now CI is 100% green.
You can see the code scanning results here: https://github.com/TheOpenSpaceProgram/osp-magnum/security/code-scanning
Thanks for the CI fixes!
This 100% finishes the pipeline rewrite and fixes everything commented-out in #244
DrawTransformObservers
from drawing_fn.h:
Other notes
One may notice that in many places I'm dropping the
m_
naming convention for structs that don't have (or have very few) member functions. Them_
is useful for member functions as C++'s implicitthis->
can make it difficult to tell which variables are or aren't member variables. If there are no member functions, then they're redundant and contribute to making my eyes bleed as I try to understand what the code is doing, so they should be removed.