search

TheOverfloater / pathos-public

Public release of Pathos Engine
MIT License
39 stars 9 forks source link

[Not an issue] Suggestion: Make cubemaps get darker if the lighting is darker #27

Closed valina354 closed 2 months ago

valina354 commented 3 months ago

i think this would enhance the graphical quality of cubemaps a lot and would prevent things like this where cubemap is very bright even in shadow image

TheOverfloater commented 3 months ago

I would need to check up on how other video games do this, cause off the top of my head I am not sure of a way to do this that properly accounts for darkness.

valina354 commented 3 months ago

I would need to check up on how other video games do this, cause off the top of my head I am not sure of a way to do this that properly accounts for darkness.

image source engine does do it somehow according to vdc but im not exactly sure how, but it seems to be related to lightmapping, so in pathos it could probably be done based on lightmap and then maybe somehow acount for dlights?? im not sure