ThePacielloGroup / ARC-Toolkit

Quickly uncover and resolve accessibility issues on any web page with TPGi’s single-page, on-demand, accessibility testing tool.
https://www.tpgi.com/arc-platform/arc-toolkit/
7 stars 1 forks source link

<iframe> elements break Toolkit's Highlight feature #40

Closed aaronbnb closed 4 months ago

aaronbnb commented 1 year ago

Describe the bug <iframe> breaks ARC Toolkit's Highlight feature.

When a page contains an <iframe> which contains an element that ARC Toolkit can highlight, ARC Toolkit highlights the elements in the viewport but does not display the element in the DevTools pane. This issue applies to all highlightable elements - such as:

For example, when a page contains an <iframe> which contains a heading nested within that <iframe>, ARC Toolkit's Highlight Headings feature highlights the headings on the page in the viewport but does not display any heading elements within the DevTools pane.

To Reproduce For this example, let's use headings or form fields:

  1. Go to a page which has an <iframe> which contains a heading (either native or ARIA role="heading") or a form field
  2. Open ARC Toolkit and select Highlight
  3. In Highlight, select Highlight Headings or Forms
  4. Note that the headings and form fields on the page (and within the <iframe>) are highlighted in the viewport but not displayed within the DevTools pane

Test Case: Acme Restaurant - test site The <iframe> contains an <h2> and multiple <input>.

Screenshots Screenshot shows that the webpage contains an iframe elements which has form fields and ARC Toolkit highlights the main page and iframe's form fields in the viewport but the devtools pane is blank Note that the DevTools pane is blank.

Expected behavior

  1. The elements highlighted in the browser viewport should also be displayed in the DevTools pane
  2. In the DevTools pane, the elements should be displayed AND indicated as being located within an <iframe>

Version information

Notes This issue was reported by an external education institution which uses ARC Toolkit.

ferllings commented 11 months ago

https://dev.azure.com/tpgarc/AAP%20Portal%20R2/_workitems/edit/9148/

Fixed in https://dev.azure.com/tpgarc/AAP%20Portal%20R2/_git/ARC.ToolKit/pullrequest/1942

poorgeek commented 4 months ago

Missed closing this when support was added in Toolkit 5.6.0