ThePacielloGroup / CCAe

The Colour Contrast Analyser (CCA) helps you determine the legibility of text and the contrast of visual elements, such as graphical controls and visual indicators.
http://www.paciellogroup.com/resources/contrastanalyser/
GNU General Public License v3.0
468 stars 105 forks source link

CCA doesn't support Windows shortcut for moving windows between displays #305

Closed PatUMW closed 10 months ago

PatUMW commented 1 year ago

Describe the bug The shortcut for moving windows between displays is Windows Key + Shift + Left or Right Key doesn't work with CCA.

Desktop (please complete the following information):

To Reproduce

  1. Open CCA on PC with two displays and move CCA to the second display.
  2. Start remote desktop session on another PC with only one display and connect to machine from point 1.
  3. Use Windows Key + Shift + Left or Right Key to move CCA window from the second display to the first one. Fail.

Expected behavior CCA will be able to move via those Windows shortcuts.

JOP-Temesis commented 11 months ago

Regularly on Windows CCA is "lost" in the screen and unreachable. Installing this shortcut could allow CCA to force its positioning.

ferllings commented 10 months ago

It seems to works fine for me. Can you test with https://github.com/ThePacielloGroup/CCAe/suites/16582749397/artifacts/947367400 ?

ferllings commented 10 months ago

Added similar feature on Macos 7b953a64bac2a98474ef09f5ed741f2ad688162f

handcoding commented 6 months ago

Added similar feature on Macos 7b953a6

@ferllings By the way, I believe that the above commit has caused a regression that has the effect of breaking some standard macOS keyboard shortcuts within all macOS applications (whenever the Color Contrast Analyzer is running).

As of CCA 3.5.1, if the Color Contrast Analyzer is running, the standard macOS keyboard shortcuts Cmd+Shift+Left and Cmd+Shift+Right no longer appear to work in any application.

macOS has standard keyboard shortcuts for selecting text, and among them are:

Here are steps to reproduce this issue on macOS if it may help:

  1. Close the Color Contrast Analyzer if it may be running.
  2. Open a new TextEdit document and paste in this text (or any other text): The quick brown fox jumped over the lazy dog.
  3. Place the cursor just after the word “fox” and then press Cmd+Shift+Left.
    • Result: ✔︎ The text from the cursor to the beginning of the line is selected.
  4. Then open CCA 3.5.1 and repeat those steps:
    1. Go back to the open TextEdit document from earlier (with the “quick brown fox” text).
    2. Place the cursor just after the word “fox” and then press Cmd+Shift+Left.
      • Expected result: The text from the cursor to the beginning of the line is selected.
      • Actual result: Nothing happens.

Just for completeness:

ferllings commented 6 months ago

@handcoding Thanks Ashley. I'll probably make those shortcuts customizable

handcoding commented 6 months ago

Right on—that sounds good, @ferllings!