search

ThePacielloGroup / WebAccessibilityToolbar

Web Accessibility Toolbar for Internet Explorer
http://www.paciellogroup.com/resources/wat
Other
68 stars 23 forks source link

IE options toggle images/css/javascript/activex don't work #89

Closed stevefaulkner closed 9 years ago

stevefaulkner commented 9 years ago

the toggle images/css/javascript/activex in IE menu don't work using IE11, windows 8.1 using isntalled version 2015-02-04

menovak commented 9 years ago

hi Steve

These 4 functions do not work on 32 bit version either (Windows 7/IE11) and I can't recall when they did work, also at a quick glance i'm not exactly sure what they call/invoke?

toggleimg=Toggleimg ToggleJS=Togglejs ToggleAX=Toggleax ToggleCSS=Togglecss

Mark

On Fri, May 1, 2015 at 9:47 AM, stevefaulkner notifications@github.com wrote:

the toggle images/css/javascript/activex in IE menu don't work using IE11, windows 8.1 using isntalled version 2015-02-04

— Reply to this email directly or view it on GitHub https://github.com/ThePacielloGroup/WebAccessibilityToolbar/issues/89.

ghost commented 9 years ago

The "WAT_IESet.exe" is necessary for those functions. I don't understand why it was deleted.

stevefaulkner commented 9 years ago

@jun325 thanks, @menovak @matatk can the WAT_IESet.exe be added back and a new release made ASAP?

matatk commented 9 years ago

The WAT_IESet.exe file will still be in the history for the repository, so should be easy to restore (in theory). I have the following questions about restoring it, to make sure it's done correctly:

  1. Where should it go? (Assuming the same place it was before.)
  2. Are there separate 32- and 64-bit versions?
  3. Does anything need to be done at install time for it, or is it just called when required?

Unfortunately I am unlikely to be able to work on this until later this week, sorry. Will get to it as soon as I can, of course.

P.S. @jun325: thanks for the information, as Steve mentioned above. If you could let me know about the above, I'll restore it as soon as I can.

matatk commented 9 years ago

Further to my last comment, I've realised that we presently have two different ways of disabling/removing CSS and images, as the following WAT options still work:

Is there a difference between these and the ones on the 'IE' menu (that's WAT > IE > *)? Do we need both different ways to do the same thing? I suspect that 'Images > Remove Images' may be different to the IE-based approach, because it leaves a note where the image was, but as the IE-based one isn't working at the moment I can't tell for sure.

@stevefaulkner @menovak: what are your thoughts on this?

stevefaulkner commented 9 years ago

@matatk the IE options actually disable stuff in the browser (by changing browser settings) and do so until they are enabled again. The 2 features you mention above are 'simulations'

matatk commented 9 years ago

@stevefaulkner: got it -- though are both really needed? I think you are saying they are -- though I feel we should also improve the docs (and possibly even rename the menu options in WAT) to reflect this. I'll file an issue on that, too, and assign myself...

menovak commented 9 years ago

Please leave the WAT version in the CSS menu as is... I've found it more reliable and makes more sense grouped where it is.

On Tue, May 5, 2015 at 4:37 AM, Matthew Tylee Atkinson < notifications@github.com> wrote:

@stevefaulkner https://github.com/stevefaulkner: got it -- though are both really needed? I think you are saying they are -- though I feel we should also improve the docs (and possibly even rename the menu options in WAT) to reflect this. I'll file an issue on that, too, and assign myself...

— Reply to this email directly or view it on GitHub https://github.com/ThePacielloGroup/WebAccessibilityToolbar/issues/89#issuecomment-99011117 .

stevefaulkner commented 9 years ago

where are we at with this?

matatk commented 9 years ago

I will work on this as soon as I'm able. If @jun325 could send answers to the three questions above that'd help (particularly questions 2 and 3), then I should be able to just go in and fix it.

ghost commented 9 years ago
  1. Where should it go? (Assuming the same place it was before.)

It's the same place.

  1. Are there separate 32- and 64-bit versions?

Yes.

  1. Does anything need to be done at install time for it, or is it just called when required?

It's just called.

matatk commented 9 years ago

Thanks @jun325; I'm on it... I think I deleted them originally because I misread something in a previous issue; sorry!

matatk commented 9 years ago

I have just uploaded a new test release with the IE settings stuff restored. However, I noticed that, when I open the IE > Internet Explorer Accessibility Options dialog, then try clicking on the Captions button in the bottom-left, nothing happens. I believe I restored everything that was needed, so am wondering if this represents a separate, but related, bug?

Note: Until we have resolved whether the captions thing is a separate bug, I've marked the release I've just made as non-production-ready, and I am not merging in my changes to master just yet.

Note 2: The Captions button doesn't appear on IE 10, only on IE 11. Is that intended?

stevefaulkner commented 9 years ago

@matatk the dialog displayed is part of IE not the toolbar, the WAT just provides easy access to the dialog.

matatk commented 9 years ago

Aha, OK, then... looks like I am OK to merge the changes, and mark this release as ready for widespread use...