search

ThePacielloGroup / inclusive-design-principles

A set of principles for designing inclusive web interfaces.
http://inclusivedesignprinciples.org/
11 stars 6 forks source link

Slightly reduce font size, make it depend on width AND height #64

Closed patrickhlauke closed 7 years ago

patrickhlauke commented 7 years ago

Instead of just considering the vw in the font size calculation, it takes into consideration vw and vh. This avoids that on landscape/widescreen setups the width of the browser window ends up having undue influence on the font size leading to an uncomfortable "letterboxing" effect.

Closes https://github.com/ThePacielloGroup/inclusive-design-principles/issues/50

patrickhlauke commented 7 years ago

Before/after comparison for landscape and portrait aspect ratios.

idp-landscape

idp-portrait

patrickhlauke commented 7 years ago

@heydon if you're definitely not going to consider this...feel free to close it :p

Heydon commented 7 years ago

@patrickhlauke I didn't realise you'd already done a pull request for this. Doesn't look much different to me, but I'll merge it anyway, since it has no conflicts 💪