search

ThePandemoniumInstitute / botc-release

The Official Blood on the Clocktower App
https://botc.app
35 stars 2 forks source link

[BUG] Custom logos no longer loading #196

Closed Lex-The-Wall closed 4 months ago

Lex-The-Wall commented 4 months ago

Description

When loading custom scripts into the official app (both browser version and downloaded app version), previously it has been possible to get custom logos in the centre using a string such as "logo":"http://www.example.com/image.png". This is currently no longer working. Yes, I have custom icons enabled.

Previously this worked with with Ben Burns' "It's Cold Outside" most recent version, that contains the following string: "logo":"https:\/\/www.bloodstar.xyz\/p\/bungeeman\/Its_Cold_Outside\/_meta.png"

Also tested with Alex S's "Fall of Rome" script most recent version, I have tried variations on the following strings: "logo":"https:\/\/www.bloodstar.xyz\/p\/AlexS\/Fall_of_Rome\/_meta.png" "logo":"https://www.bloodstar.xyz/p/AlexS/Fall_of_Rome/_meta.png"

It is worth noting that custom background images ARE still working (using the string "background":"url"), only logos that have stopped working.

Has this functionality been removed, or has something been changed or broken?

(User ID 6351995109530 if you need to discuss, or Lex on official Discord)

Steps to reproduce

Write and load any script that should have its own logo. Here is a REALLY stripped-down version of Fall of Rome that should have no other clashes, to illustrate: Fall of Wrong.json

Browser

Firefox Brave Official app (downloaded version)

Operating System

Windows

Date and Time

11th June 2024 @ 10:00 BST

Game Session

No response

Relevant console log output

No response

Lex-The-Wall commented 4 months ago

Got it working, but with a very counter-intuitive workaround. The theme needs to be set to one of the custom themes in order to load custom logos.

So this can become a UI improvement suggestion: when loading custom scripts, the app should automatically select a custom theme.

bra1n commented 4 months ago

Hi @Lex-The-Wall, this has always been the case - the default themes in the app (those with the "purple" background) did not support showing a custom script logo. That said, I think the idea to select a custom script theme that has space for a logo makes sense in cases where you're loading a custom script with a logo. I'll add it to the next update.