search

ThePandemoniumInstitute / botc-release

The Official Blood on the Clocktower App
https://botc.app
35 stars 2 forks source link

[BUG] Error that caused character tokens to be messed up #218

Closed apophisnow closed 2 months ago

apophisnow commented 2 months ago

Description

Randomly after a game the character tokens became messed up.

Steps to reproduce

Unknown, but probably when ST was adjusting seats and people were leaving and joining the lobby.

Screenshot 2024-09-05 at 10 12 22 PM

Browser

Chrome

Operating System

Mac

Date and Time

2024-09-06T04:39:38.637Z

Game Session

https://botc.app/join/stuffnthings

Relevant console log output

2024-09-06T04:39:38.637Z - chrome 127.0.0 Mac OS - #stuffnthings
TypeError: Cannot set properties of null (setting 'value')
    at Proxy.handleAvatarUpload (https://botc.app/assets/index-zlelDgJd.js:9:48282)
apophisnow commented 2 months ago

The issue persists after a refresh of the page as well. It appears to be impacting only empty seats that are added/removed.

bra1n commented 2 months ago

That's not a bug, but the way it currently looks like - empty seats / disconnected players won't show an avatar. This will be changed with the next update, however.

apophisnow commented 2 months ago

My expectation is that they would be the same size as the other tokens. No problem with them not showing an avatar.

bra1n commented 2 months ago

Agreed, which is why this will be changed in the upcoming update. :-)