ThePansmith / Monifactory

A Modern Remaster of Nomifactory
GNU Lesser General Public License v3.0
215 stars 107 forks source link

Restore alternative reciepe for oak drawers using only chests. #1120

Closed tomprince closed 6 days ago

tomprince commented 6 days ago

These were removed in #826 to fix #782. However, I think the behaviour is working (at least mostly) as intended. It is definitely intended that you can craft oak drawers without needing planks, shift clicking allowing crafting different recipes with the same output is slightly surprising.

This is a slightly cheaper, but avoids there being a micro-optimization of using 4x drawers instead of 1x drawers as crafting ingredients (since 4x drawers cost 9.25 planks vs 16 for 1x drawers). With these recipes, they can both cost 8 planks unless you want different textures.

Xefyr0 commented 6 days ago

Unfortunately, the behavior is most certainly not working as intended. If you decompile the mod jar and look at the recipe JSONs, you can see that the original recipe expects any item with the functionalstorage:woodless "type", which is as far as I know is invalid and thus ignored. This causes the recipe to complete without any such item necessary.

The micro-optimization argument also falls flat, since there are similar bugged recipes for the 1x2 and 2x2 oak drawers.

If you don't feel like decompiling a mod jar, you can find the recipe JSON files attached below: oak_drawer_alternate_x1.json oak_drawer_alternate_x2.json oak_drawer_alternate_x4.json

Frankly, if you want to go report this bug on Functional Storage's repo on our behalf that'd be very helpful: https://github.com/Buuz135/FunctionalStorage/issues

tomprince commented 6 days ago

The micro-optimization argument also falls flat, since there are similar bugged recipes for the 1x2 and 2x2 oak drawers.

I'm not sure what you mean. My point is that the default recipies for the 1x1, 1x2 and 2x2 drawers take 16, 11.5 and 9.5 planks respectively. So, if you care about optimizing plank usage, it makes more sense to make 2x2 drawers as input to crafting recipies (such drawer upgrades, compacting drawers, controllers). The alternative recipes cost a flat 8 planks per drawer.

Particularly when using framed drawers, it seems sensible to allow you to craft drawers without needing a specific type of plank.

tomprince commented 6 days ago

Also, whether or not the recipes are intentional, I find them a nice QoL things that lets you not worry about what type of wood you have, but get a consistent style of drawers.