ThePansmith / Monifactory

A Modern Remaster of Nomifactory
GNU Lesser General Public License v3.0
192 stars 99 forks source link

[Bug]: My Steam turbine producing only 40 RF/t #968

Open WarZzo opened 4 days ago

WarZzo commented 4 days ago

Issue Summary

I was looking at this video : (https://youtu.be/LVSTXlasny4?si=qBObd-cKa4f1GRu1&t=1131) and when i reproduced the setup i realized that mine only produced 40 RF/T non modified and seems a bit low.

Reproduction steps

  1. Place stream boiler
  2. pipe it to the steam turbine
  3. open energy menu 4.only 40RF/T image

Relevant log output

No response

Kasra-G commented 2 days ago

Noticed this as well, I thought the change here #735 was only supposed to change the fuel efficiency of the boiler?

Seems that it was a side effect of the change. These lines are probably the cause: https://github.com/ThePansmith/Monifactory/pull/735/files#diff-8dd987cccec93b1f50c15f125a8bbff3d674d9738414fea90b973e7a1b015767L8-R8

Edit: Can confirm that changing the multiplier back to 4.0 in the config brings back the 160 rf/t turbines

MightyPiggie commented 2 days ago

Edit: Can confirm that changing the multiplier back to 4.0 in the config brings back the 160 rf/t turbines

If that is indeed the issue try updating the pack to the latest version. The change should be reverted back to 4.0: https://github.com/ThePansmith/Monifactory/commit/87efb2ddb0ae59e2a1b460662a8acb8037d4b368#diff-8dd987cccec93b1f50c15f125a8bbff3d674d9738414fea90b973e7a1b015767R8

sp4rkyd4rk commented 1 day ago

Heya! Changing it server-wide didn't help me. Even though I'm now updated to 0.9.10 version of the pack (the one from 17 hours ago from time of posting). Both upgraded and regular turbines are still on 40 and 60 rf/t. And my defaultconfigs/systeams-server.toml is reversed to 4.0 multi. Server's running on forge-1.20.1-47.3.7 build. The one being recommended when I launched my server first time. I'm kinda confused rn about what to do with that. I tried crafting new turbines, reseating previous ones, reseating upgrade, changing multiplier couple times more. Nothing happened and idk why.

image image image

WarZzo commented 1 day ago

You have a systeams-servers file in the save file you need to chnage it there for it to work or at least that worked for me and becarful you need to have your game close for the file to save.( May work if in main menu dont know never tested)

Kasra-G commented 1 day ago

This goes back to the way configs are handled by Forge. Changes in defaultconfigs will not change existing worlds. The original user had this issue because they created a new world after the issue was introduced but before it was fixed again.

If you actually want the defaultconfig changes to propagate you will need to stop the world, delete/overwrite the file that had changes (in this case, serverconfig/systeams-server.toml) in your save folder, and launch the world.

I forget if there's a more integrated way to do this, but regardless it would be nice if we could get a message in the release notes if the defaultconfig folder was modified so that we can know to manually overwrite the serverconfig files in our levels with the new configs.

sp4rkyd4rk commented 1 day ago

Hey! Thanks for the heads-up! Never noticed that serverconfig folder, gotta try it out. Also that's also the way I got my world into the issue, the world was started in 0.9.7 which already had it.

Never used forge on "new" versions so I didn't know defaultconfig propagates into every new world generated. Cheers!

On Mon, Oct 21, 2024, 04:44 Kasra Ghaffari @.***> wrote:

This goes back to the way configs are handled by Forge. No changes in defaultconfigs will change existing worlds. The original user had this issue because they created a new world after the issue was introduced but before it was fixed again.

If you actually want the defaultconfig changes to propagate you will need to delete/overwrite the file that had changes (in this case, serverconfig/systeams-server.toml) in your save folder and reload the world.

I forget if there's a more integrated way to do this, but regardless it would be nice if we could get a message in the release notes if the defaultconfig folder was modified so that we can know to manually overwrite the serverconfig files in our levels with the new configs.

— Reply to this email directly, view it on GitHub https://github.com/ThePansmith/Monifactory/issues/968#issuecomment-2425295013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARI2F6MNQDKU75W55PCJS23Z4Q57TAVCNFSM6AAAAABQEZT4UKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGI4TKMBRGM . You are receiving this because you commented.Message ID: @.***>