ThePerfectComputer / FastWaveBackend

A Rust VCD parser intended to be the backend of a Waveform Viewer(built using egui) that supports dynamically loaded rust plugins.
GNU General Public License v3.0
42 stars 5 forks source link

I am having compilation issues for `signal`. #39

Open furkanturan opened 10 months ago

furkanturan commented 10 months ago

I am having compilation issues for signal. Apparently, the query_string_val_on_tmln function is removed from the signal with a commend that says

(zoq) I am removing thse because they aren't used in Surfer so I can't test them properly

However, the main() directly depends on it.

Are there any pointer for resolving the issue?


user@computer:~/FastWaveBackend$ rustup default stable
info: using existing install for 'stable-x86_64-unknown-linux-gnu'
info: default toolchain set to 'stable-x86_64-unknown-linux-gnu'

  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.70.0 (90c541806 2023-05-31)

user@computer:~/FastWaveBackend$ cargo run --release --example vcd
   Compiling autocfg v1.1.0
   Compiling proc-macro2 v1.0.76
   Compiling unicode-ident v1.0.12
   Compiling utf8parse v0.2.1
   Compiling colorchoice v1.0.0
   Compiling anstyle-query v1.0.2
   Compiling anstyle v1.0.4
   Compiling strsim v0.10.0
   Compiling heck v0.4.1
   Compiling clap_lex v0.6.0
   Compiling iana-time-zone v0.1.59
   Compiling either v1.9.0
   Compiling anstyle-parse v0.2.3
   Compiling itertools v0.11.0
   Compiling anstream v0.6.5
   Compiling num-traits v0.2.17
   Compiling num-integer v0.1.45
   Compiling num-bigint v0.4.4
   Compiling num-iter v0.1.43
   Compiling num-rational v0.4.1
   Compiling clap_builder v4.4.14
   Compiling quote v1.0.35
   Compiling syn v2.0.48
   Compiling num-complex v0.4.4
   Compiling chrono v0.4.31
   Compiling clap_derive v4.4.7
   Compiling num v0.4.1
   Compiling clap v4.4.14
   Compiling fastwave_backend v0.1.0 (/home/fturan/FastWaveBackend)
error[E0599]: no method named `query_string_val_on_tmln` found for struct `Signal` in the current scope
  --> examples/vcd.rs:76:32
   |
76 |         let val = state_signal.query_string_val_on_tmln(&time, &vcd).unwrap();
   |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `query_val_on_tmln`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `fastwave_backend` (example "vcd") due to previous error
TheZoq2 commented 10 months ago

Oh interesting, I guess I never tested the examples after removing that function :thinking:. Since it worked and compiled as a library I was happy

Thanks for the report

If you'd like to take a stab at fixing it, the commit that broke these is probably in https://github.com/ThePerfectComputer/FastWaveBackend/pull/36 and should just be a matter of reverting the removal of that function