search

ThePhD / infoware

C++ Library for pulling system and hardware information, without hitting the command line.
Creative Commons Zero v1.0 Universal
410 stars 84 forks source link

Remove carriage return on CRLF encoded files #58

Closed voldien closed 2 years ago

voldien commented 2 years ago

The PCI generator will fail to generate a correct header file, because of a new line after the vendor name string, if the pci.ids file were encoded with CRLF.

Though the problem originated from that my git was configured with auto CRLF encoding, so there is no problem with original encoding, but for systems that are using auto CRLF, the compilation will break.

nabijaczleweli commented 2 years ago

What sort of weird-ass configuration?.. But fair enough, I guess.

voldien commented 2 years ago

Apprently, it was the following git configuration setting, git config --global core.autocrlf true that cause the pci.ids to be encoded as CRLF.