ThePhD / infoware

C++ Library for pulling system and hardware information, without hitting the command line.
Creative Commons Zero v1.0 Universal
410 stars 84 forks source link

Small fix in OS_info for windows; CMakeLists.txt - add config option to exclude PCI easily #77

Closed pavel-a closed 1 week ago

pavel-a commented 1 week ago

In os_info_windows.cpp, version_name() :

nabijaczleweli commented 1 week ago

First patch applied (with minor editorial) as c8da4c2b8541987a7cd664a537eeabf6c87dfbe1. For the second one, replace the CMake filter with a #if[n]def INFOWARE_... in pci.cpp; compare, say, src/gpu/d3d.cpp:

#ifndef INFOWARE_USE_VULKAN
#ifdef INFOWARE_USE_D3D

and in the example, add the same ifdef/ifndef after the version listing, say "compiled without PCI support" or whatever. Also don't change the version.

pavel-a commented 1 week ago

done partially, sent new