Make easy to exclude PCI ids functionality in CMakeLists.txt

ThePhD / infoware

C++ Library for pulling system and hardware information, without hitting the command line.

Creative Commons Zero v1.0 Universal

410 stars 84 forks source link

Make easy to exclude PCI ids functionality in CMakeLists.txt #78

Closed pavel-a closed 1 week ago

pavel-a commented 1 week ago

The intent of exclusion of big blob in CMakeLists.txt by if(INFOWARE_USE_PCIIDS) is that it does lot of fuss with searching git, then clone something, compiling and running some utility.... all what users who do not want PCI IDs functionality even do not want to see.

Alternative is to provide small dummy pci.ids file and go build with it... but why.

nabijaczleweli commented 1 week ago

You could've just updated that one, but sure.

Editorialised a bit, applied in 79f0aa5864322b041c1660845fdc7f7fce2af69a; thanks!

pavel-a commented 1 week ago

Mucho spasibo Nab, you're a lightning ))