ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:
http://sol2.rtfd.io/
MIT License
4.2k stars 516 forks source link

✨ New exhaustive check feature #1412

Closed ShepherdSoasis closed 1 year ago

ShepherdSoasis commented 2 years ago

This Pull Request adds a new exhaustiveness check feature. The tests were updated, and some general fixes were applied in line with what @ThePhD asked for earlier.

ShepherdSoasis commented 1 year ago

We fixed some of the compilation errors on this PR (finally). The tests still fail due to some issues with the automatic lua pulling and building system; we feel this should be fixed soon. Nevertheless,

ok to merge?

ThePhD commented 1 year ago

Yes, sorry; thanks for doing this. This will help immensely with allowing overriding in this specific case, and cleaning up the assert macro was very helpful. There's more to do in this direction but I think this helps enough. I need to clean up the tests and similar so that we have a proper working point, but there is.... SO much to fix in this repository....