Release 3.3.0 single headers have wrong version info

ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:

http://sol2.rtfd.io/

MIT License

4.12k stars 500 forks source link

Release 3.3.0 single headers have wrong version info #1425

Open cmsquared opened 1 year ago

cmsquared commented 1 year ago

On the GitHub release page, the single header assets sol.hpp and forward.hpp for release 3.3.0 have version information referencing 3.2.3:

#define SOL_VERSION_MAJOR 3
#define SOL_VERSION_MINOR 2
#define SOL_VERSION_PATCH 3
#define SOL_VERSION_STRING "3.2.3"

Looks like a simple oversight while generating the release. I have not checked previous released versions for the same oversight.

cmsquared commented 1 year ago

I just went back and looked at the assets for the 3.2.3 release, and they actually reference "3.5.0" It also looks like this isn't ever used in the headers, so in practice this is currently a non-issue.