search

ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:
http://sol2.rtfd.io/
MIT License
4.12k stars 500 forks source link

Allow compiling with the CUDA 11.4 compiler #1428

Closed ibaned closed 1 year ago

ibaned commented 1 year ago

Hello,

This pull request allows sol2 to be compiled by version 11.4 of the CUDA C++ compiler nvcc. It essentially consists of workarounds for compiler bugs, and I certainly understand the annoyance of changing one's code due to bad compilers, but if this is merged then the mainline version of sol2 will be able to support our High Performance Computing codes with no modifications.

Thank you for any time you spend reviewing this and considering it for merging, please let me know if there is anything I can do to help.

I don't think it should change any behavior, although the construction of a pointer by forwarded arguments change might be worth a look by someone with deeper C++ knowledge.

ibaned commented 1 year ago

For the time being we've decided to go a different route that doesn't use sol2, so I'll close this to not take up developer time.