ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:
http://sol2.rtfd.io/
MIT License
4.12k stars 500 forks source link

🛠 Review exhaustive check and get rid of a few Wall/pedwarn warnings #1439

Closed ShepherdSoasis closed 1 year ago

ShepherdSoasis commented 1 year ago

We reviewed the exhaustive check/get warnings and manually tested it on Windows and Linux machines with Visual Studio (Windows) and GCC 9, 11 (Debian & Ubuntu).

The tests are passing, we manually added them to the general build, and further testing seems to indicate the feature is working as expected. We are in communication with a few stakeholders to obtain more relevant information, but this PR is just a general cleanup of the feature. OK to pull?