ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:
http://sol2.rtfd.io/
MIT License
4.18k stars 515 forks source link

No error on argument type mismatch for optional with SOL_SAFE_NUMERICS #1552

Open glebm opened 10 months ago

glebm commented 10 months ago

I have a function like this:

void f(std::optional<uint8_t> x);

The intent is that it can be called from Lua with or without an argument.

So this works:

-- passes nullopt
f()

-- passes 1
f(1)

However, the following also works and passes nullopt!

-- passes nullopt!
f('string')

This seems like a bug. I'd prefer it to raise a Lua error instead!

My sol2 config:

#define SOL_SAFE_USERTYPE 1
#define SOL_SAFE_REFERENCES 1
#define SOL_SAFE_FUNCTION_CALLS 1
#define SOL_SAFE_FUNCTION 1
#define SOL_SAFE_NUMERICS 1
#define SOL_IN_DEBUG_DETECTED 0