Add limits header explicitly to be compatible with gcc11

ThePhD / sol2

Sol3 (sol2 v3.0) - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great! Documentation:

http://sol2.rtfd.io/

MIT License

4.06k stars 492 forks source link

Add limits header explicitly to be compatible with gcc11 #1590

Closed JKraso closed 3 months ago

JKraso commented 3 months ago

Based on https://gcc.gnu.org/gcc-11/porting_to.html Header dependency changes, new versions >gcc10 have removed some implicit includes (again) which causes codebases relying on those to fail.

This little line will fix compatibility with gcc11

Rochet2 commented 3 months ago

The header is already added above on line 43. It was added in this commit https://github.com/ThePhD/sol2/commit/e5e6466e09b632677d24a8f204d6a0ea0a8862b1

How did you get the error? Were you using latest sol? (v3.3.0)

JKraso commented 3 months ago

Wow ok. I'm using CPM and even though it told me it's version 3.3.0 i guess it was still the old one. Sorry about that.

Edit: I've just opened github dev and added the header just as I did locally in the old version. Eh. Hands faster than brain.