ThePinkPanzer / Godherja-Github-Version

The Github repository for Godherja, giving another facet for users to download versions of the mod as well as serve as our main error reporting channel
7 stars 3 forks source link

Noble Legon court position "nonhuman foreigner" malus applies to ALL courtiers #754

Open chspangar opened 3 months ago

chspangar commented 3 months ago

Godherja version 0.3.1.2

The patch notes for the latest version mention that the Noble Legon court position issue where everyone is considered a "nonhuman foreigner" was fixed. However, I ran a Hecaeda game, and the bug still persists:

image

I decided to look at the code in GH_court_position.txt, and saw that the limit is scoped from the liege's religion and cultural heritage. Something is broken there as even if almost no courtier follows Hecaeda's Aironoian Aagiokratia religion, most courtiers are Eastern Aversarias as she is, so the cultural heritage scope should work.

Workaround I implemented: Instead of searching for the liege's scopes, I decided to hardcode the limit to non-Aversarian heritage nor Aversarian faiths:

if = { # A non-human as a Legon!?
            limit = {
                NOR = {
                    #faith.religion = scope:liege.religion                  
                    #culture = { has_same_culture_heritage = scope:liege.culture }
                    religion = religion:aversarinas_aagiokrata_religion
                    culture = { has_cultural_pillar = heritage_aversarian }
                }
            }
            add = {
                value = -75
                desc = court_position_nonhuman
            }
        }

This might not be an elegant solution and it's a bit of hardcoding, but at least it consistently keeps Aversarian courtiers from being limited to the Legon position.