search

ThePix / QuestJS

A major re-write of Quest that is written in JavaScript and will run in the browser.
MIT License
66 stars 13 forks source link

Mobile styles #23

Open mvultgmr opened 3 years ago

mvultgmr commented 3 years ago

Hi, Pix. I had some ideas for adding mobile breakpoints to style.css, so I forked the project and did some revisions. I'm new to GitHub so am not sure if this is the right way to do things, but here is a link to my version. Feel free to play with!

https://github.com/mvultgmr/QuestJS/commit/c4079a2ddd4664aa5661c353788babfae3e73252

ThePix commented 3 years ago

Just to let you know, I am thinking about this. I think it is important, I am not sure the best way to proceed. Part of that is that the author should have some choice about whether the side pane (and anything else, map?) disappears, depending on what the authors thinks is the primary way to play the game.

mvultgmr commented 3 years ago

Yeah, I wasn't sure immediately what to do with the side pane and map items. The solution usually is to move all that to a hamburger menu; perhaps something for you to think about. In the meantime, you might preserve this code as a starting point for authors who want to attempt it, either as commented-out code or within a help file.

I'm glad the project seems to be going well!

ThePix commented 3 years ago

I have made a small step, it that now features disappear if the width is narrow. https://github.com/ThePix/QuestJS/wiki/Responsive-Games

May need more consider, eg your hamburger idea; we will see how it goes.

mvultgmr commented 3 years ago

Great job. Mobile styling is a tedious bitch, but having these features will make things so much more accessible.

Also great job on the map function!

KVonGit commented 3 years ago

I tried to check out the code by @mvultgmr, but the link was dead.

One of the things on my QuestJS to-do list is to add the hamburger-style menu for the panes when on mobile.

Also, I wanted to see if those mobile settings were better than my mobile settings (which are rudimentary, at best).

mvultgmr commented 3 years ago

Shit, sorrry, @KVonGit . I purged the repo once I thought Pix was done with it. But if you'd like to share your code, I'd be be happy to spitball it. :)

mvultgmr commented 2 years ago

Here is the mobile styling code that I wrote last October, FWIW. I believe a the developer has devised better options for mobile styling since then. style-mobile.txt