ThePix / QuestJS

A major re-write of Quest that is written in JavaScript and will run in the browser.
MIT License
66 stars 13 forks source link

io.toggleDarkMode does not update io.textColour (minor) #24

Closed Kln95130 closed 3 years ago

Kln95130 commented 3 years ago

This causes the compass links to return to the black colour when an input is asked (for instance, through a showMenu). This is probably because io.textColour is a variable, and not a getter.

The best solution would be to add io.textColour = $(".side-panes").css("color"); to the io.toggleDarkMode function, Changing textColour to a getter function would mean accessing the css selector at each call, which is not optimal.

ThePix commented 3 years ago

Thanks, now corrected