Can't set lobby size to 16

ThePooN / bancho.js

Interface with Bancho over IRC, made easy and reliable.

https://bancho.js.org

GNU General Public License v3.0

57 stars 6 forks source link

Can't set lobby size to 16 #11

Closed kiwec closed 2 years ago

kiwec commented 3 years ago

Lobby size is limited to 15, when it should be limited to 16.

https://github.com/ThePooN/bancho.js/blob/ab3f14fb76e4ecb8062efca537c83befe3e9c6e1/lib/Multiplayer/BanchoLobby.js#L580

An exception is thrown but bancho accepts the command just fine when you type it in manually. Sorry for making an issue on github for a 1-character fix, discord doesn't like my IP :(

ThePooN commented 3 years ago

Well it's not limited to 16... but that conditional is very wrong either way.

I remember coding most of bancho.js's multiplayer support in a single night and there it shows.

ThePooN commented 2 years ago

Fixed in 0.10.0-rc.6