[BUG] Missing colorization on CrackMapExec

ThePorgs / Exegol-images

Docker images of the Exegol project

https://exegol.readthedocs.io/

GNU General Public License v3.0

81 stars 63 forks source link

[BUG] Missing colorization on CrackMapExec #202

Closed QU35T-code closed 1 year ago

QU35T-code commented 1 year ago

Describe the bug

CME cannot combine colors with grc.

ShutdownRepo commented 1 year ago

Re-opening. Quick fix was to unset the cme alias that was relying on grc to colorize output. This was needed before CME included the right changes in its code to allow proper colorization. Now, we just need to create a PR on CrackMapExec with the colorization of SMB1 enabled/disabled and SMB signing True/False. Will close this this issue once PR is created on CME's repo

ShutdownRepo commented 1 year ago

Tried to create a PR but I'm facing a code that isn't made for these changes. The way CME logs things on protocols (smb, ldap, etc.) doesn't allow for easy colorization using rich like they're doing on the base. I created an issue to propose that feature. Hopefully they'll implement it... Closing here, as there's nothing to be done now on our end...

QU35T-code commented 1 year ago

The CME team fixed the problem and added the colors in this PR : https://github.com/mpgn/CrackMapExec/pull/93 - https://github.com/mpgn/CrackMapExec/issues/92