[BUG] `install_java11` fails because only mac binaries are in the latest release - Githubissues

ThePorgs / Exegol-images

Docker images of the Exegol project

https://exegol.readthedocs.io/

GNU General Public License v3.0

87 stars 67 forks source link

[BUG] `install_java11` fails because only mac binaries are in the latest release #291

Closed compass-dexter closed 7 months ago

compass-dexter commented 8 months ago

Describe the bug

The latest release of adoptium/temurin11-binaries (https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.22%2B7.1) only contains mac binaries. Therefore the build fails.

Instead of using https://api.github.com/repos/adoptium/temurin11-binaries/releases/latest in package_base.sh we should use https://api.github.com/repos/adoptium/temurin11-binaries/releases and pipe it to sort | tail -n1.

Steps To Reproduce

Build the image and wait until install_java11 is called.

Exegol Wrapper Version

N/A

Exegol container information

N/A

Exception

No response

Additional context

No response

Anything else?

No response

QU35T-code commented 7 months ago

Merged ! Thanks @compass-dexter