search

ThePorgs / Exegol-images

Docker images of the Exegol project
https://exegol.readthedocs.io/
GNU General Public License v3.0
73 stars 56 forks source link

Adding tool ASRepCatcher #321

Closed Yaxxine7 closed 2 months ago

Yaxxine7 commented 3 months ago

Adding ASRepCatcher tool in AD package

QU35T-code commented 2 months ago

The proposal to add this tool is under consideration because it requires network configuration and the exegol container may need additional capabilities.

Yaxxine7 commented 2 months ago

The tool includes a container environment detection feature and tells the user to run it in another privileged container if the current one is not privileged : image

QU35T-code commented 2 months ago

What do you think @ShutdownRepo / @Dramelac ?

Dramelac commented 2 months ago

Why not, but it would be better to use --cap parameter instead of privileged if you known the right capabilities to add to the container.

QU35T-code commented 2 months ago

@Yaxxine7, can you check if NET_ADMIN is enough ?

Yaxxine7 commented 2 months ago

I just made some modifications to make the NET_ADMIN capability sufficient.

ShutdownRepo commented 2 months ago

@Yaxxine7 do you mind fixing the conflict, and synchronizing with latest dev, so that I can run the pipeline properly?

QU35T-code commented 2 months ago

@Yaxxine7 can you update the test command ? Needs to return 0

IMG_0602

Yaxxine7 commented 2 months ago

Oh, my bad it should be good now.