[BUG] packages.list file, necessary empty line

lap1nou commented 2 months ago

Describe the bug

Greetings,

I don't know if it's a bug or not, but creating a packages.list in my-resources without an empty line at the end doesn't actually install the packages.

Maybe it's not a bug, but personally I was confused as of why my package wasn't installing but maybe I'm alone.

Steps To Reproduce

Create or modify a packages.list in my-resources like that:

# The customization of some tools may require the installation of some packages or other dependencies.
# To simplify this process, the name of the packages to be installed can be listed in this file.
# All packages listed below will be installed automatically when creating a new Exegol container.
eza

keys.list:

https://raw.githubusercontent.com/eza-community/eza/main/deb.asc

sources.list:

deb http://deb.gierens.de stable main

Start an Exegol container, the eza package (or any specified package) should be installed but it's not, in order to fix it, one should add an empty line at the end of the file:

# The customization of some tools may require the installation of some packages or other dependencies.
# To simplify this process, the name of the packages to be installed can be listed in this file.
# All packages listed below will be installed automatically when creating a new Exegol container.
eza
<----- HERE

Exegol Wrapper Version

[*] Exegol is currently in version v4.3.1
[*] Exegol Discord serv.: https://discord.gg/cXThyp7D6P
[*] Exegol documentation: https://exegol.rtfd.io/
[+] We thank Capgemini for supporting the project (helping with dev) 🙏
[+] We thank HackTheBox for sponsoring the multi-arch support 💚
[D] Pip installation: On ✔
[D] Git source installation: Off 🪓
[D] Host OS: Linux (Kernel)
[D] Arch: amd64
[D] Raw arch: x86_64
[D] Docker desktop: Off 🪓
[D] Shell type: Linux
[D] Last wrapper update check: 07/04/2024

Exegol container information

┌──────────────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│             Name │ TEST                                                                                                                                              │
│            Image │ full - v.3.1.2 (Up to date) (amd64)                                                                                                               │
├──────────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│          Comment │ Exegol container for the machine TEST                                                                                                             │
│      Credentials │ root : $PASSWORD                                                                                                             │
│          Desktop │ Off 🪓                                                                                                                                            │
│    Creation date │ 12/04/2024 20:13                                                                                                                                  │
│              X11 │ On ✔                                                                                                                                              │
│          Network │ bridge with VPN                                                                                                                                   │
│         Timezone │ Off 🪓                                                                                                                                            │
│ Exegol resources │ On ✔ (/opt/resources)                                                                                                                             │
│     My resources │ On ✔ (/opt/my-resources)                                                                                                                          │
│    Shell logging │ On ✔ (/workspace/logs)                                                                                                                            │
│              VPN │ VPN.conf                                                                                                                                         │
│       Privileged │ Off ✔                                                                                                                                             │
│     Capabilities │ NET_ADMIN                                                                                                                                         │
│        Workspace │ Dedicated (/workspace)                                                                                                                            │
│          Devices │ /dev/net/tun:/dev/net/tun:rwm                                                                                                                     │
│             Envs │ DISPLAY=:0                                                                                                                                        │
│                  │ _JAVA_AWT_WM_NONREPARENTING=1                                                                                                                     │
│                  │ QT_X11_NO_MITSHM=1                                                                                                                                │
│                  │ EXEGOL_START_SHELL_LOGGING=asciinema                                                                                                              │
│                  │ EXEGOL_START_SHELL_COMPRESS=True                                                                                                                  │                                                                                                                                  
│                  │ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin                                                                                 │
│          Volumes │ (RW) /root/.exegol/workspaces/TEST ➡ /workspace                                                                                                   │
│                  │ (RO) /nix/store/y79bsl7bc530pg0kdff560ldd6c12qxi-python3.11-exegol/lib/python3.11/site-packages/exegol/utils/imgsync/spawn.sh ➡ /.exegol/spawn.sh │
│                  │ (RW) /tmp/.X11-unix ➡ /tmp/.X11-unix                                                                                                              │
│                  │ (RW) /root/.exegol/my-resources ➡ /opt/my-resources                                                                                               │
│                  │ (RW) /root/.exegol/exegol-resources ➡ /opt/resources                                                                                              │
│                  │ (RO) /root/VPN.conf ➡ /.exegol/vpn/config/client.ovpn                                                                                             │
│         Systctls │ net.ipv6.conf.all.disable_ipv6 = 0                                                                                                                │
└──────────────────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

Exception

No response

Additional context

No response

Anything else?

No response

QU35T-code commented 2 months ago

Hey @lap1nou,

Cannot reproduce, can you retry with the dev branch ? (Exegol is currently in version v4.3.2b1 [dev-6c29d34a]) Also, can you send the output of the following commands ?

cat -e /Users/qu35t/.exegol/my-resources/setup/apt/sources.list
cat -e /Users/qu35t/.exegol/my-resources/setup/apt/packages.list
cat -e /Users/qu35t/.exegol/my-resources/setup/apt/keys.list

sources.list

❯ cat -e /Users/qu35t/.exegol/my-resources/setup/apt/sources.list
# This file allows to add apt repository, in order to install various packages later on$
# At the first start of an exegol container, this file will be copied to /etc/apt/sources.list.d/exegol_user_sources.list$
deb http://deb.gierens.de stable main$

packages.list

❯ cat -e /Users/qu35t/.exegol/my-resources/setup/apt/packages.list 
# The customization of some tools may require the installation of some packages or other dependencies.$
# To simplify this process, the name of the packages to be installed can be listed in this file.$
# All packages listed below will be installed automatically when creating a new Exegol container.$
eza$

keys.list

❯ cat -e /Users/qu35t/.exegol/my-resources/setup/apt/keys.list
# This file allows to automatically register a list of keys (using 'apt-key add') to add additional trusted repositories$
https://raw.githubusercontent.com/eza-community/eza/main/deb.asc$

Run :

> exegol start try

root@exegol-try /workspace # eza --help
Usage:
  eza [options] [files...]

lap1nou commented 2 months ago

Greetings @QU35T-code and thank you for your help,

$ exegol info

[*] Exegol is currently in version v4.3.2
[*] Exegol Discord serv.: https://discord.gg/cXThyp7D6P
[*] Exegol documentation: https://exegol.rtfd.io/

🛸 Available images
┌───────────┬─────────┬──────────────────────┐
│ Image tag │ Size    │ Status               │
├───────────┼─────────┼──────────────────────┤
│ full      │ 50.3GB  │ Up to date (v.3.1.3) │
│ nightly   │ ~55.4GB │ Not installed        │
│ web       │ ~24.8GB │ Not installed        │
│ osint     │ ~14.5GB │ Not installed        │
│ light     │ ~16.0GB │ Not installed        │
│ ad        │ ~40.5GB │ Not installed        │
└───────────┴─────────┴──────────────────────┘

👽 Available containers
┌───────────────┬─────────┬───────────┬────────────────────────┐
│ Container tag │ State   │ Image tag │ Configurations         │
├───────────────┼─────────┼───────────┼────────────────────────┤
│ test          │ Running │ full      │ Share timezone: Off 🪓 │
└───────────────┴─────────┴───────────┴────────────────────────┘

$ hexdump -C /root/.exegol/my-resources/setup/apt/packages.list

00000000  23 20 54 68 65 20 63 75  73 74 6f 6d 69 7a 61 74  |# The customizat|
00000010  69 6f 6e 20 6f 66 20 73  6f 6d 65 20 74 6f 6f 6c  |ion of some tool|
00000020  73 20 6d 61 79 20 72 65  71 75 69 72 65 20 74 68  |s may require th|
00000030  65 20 69 6e 73 74 61 6c  6c 61 74 69 6f 6e 20 6f  |e installation o|
00000040  66 20 73 6f 6d 65 20 70  61 63 6b 61 67 65 73 20  |f some packages |
00000050  6f 72 20 6f 74 68 65 72  20 64 65 70 65 6e 64 65  |or other depende|
00000060  6e 63 69 65 73 2e 0a 23  20 54 6f 20 73 69 6d 70  |ncies..# To simp|
00000070  6c 69 66 79 20 74 68 69  73 20 70 72 6f 63 65 73  |lify this proces|
00000080  73 2c 20 74 68 65 20 6e  61 6d 65 20 6f 66 20 74  |s, the name of t|
00000090  68 65 20 70 61 63 6b 61  67 65 73 20 74 6f 20 62  |he packages to b|
000000a0  65 20 69 6e 73 74 61 6c  6c 65 64 20 63 61 6e 20  |e installed can |
000000b0  62 65 20 6c 69 73 74 65  64 20 69 6e 20 74 68 69  |be listed in thi|
000000c0  73 20 66 69 6c 65 2e 0a  23 20 41 6c 6c 20 70 61  |s file..# All pa|
000000d0  63 6b 61 67 65 73 20 6c  69 73 74 65 64 20 62 65  |ckages listed be|
000000e0  6c 6f 77 20 77 69 6c 6c  20 62 65 20 69 6e 73 74  |low will be inst|
000000f0  61 6c 6c 65 64 20 61 75  74 6f 6d 61 74 69 63 61  |alled automatica|
00000100  6c 6c 79 20 77 68 65 6e  20 63 72 65 61 74 69 6e  |lly when creatin|
00000110  67 20 61 20 6e 65 77 20  45 78 65 67 6f 6c 20 63  |g a new Exegol c|
00000120  6f 6e 74 61 69 6e 65 72  2e 0a 65 7a 61 0a        |ontainer..eza.|
0000012e

I believe your packages.list file is not the same as mine, this one doesn't work:

$ cat -e /root/.exegol/my-resources/setup/apt/packages.list
# The customization of some tools may require the installation of some packages or other dependencies.$
# To simplify this process, the name of the packages to be installed can be listed in this file.$
# All packages listed below will be installed automatically when creating a new Exegol container.$
eza

but this one works fine but it got a LF at the end:

$ cat -e /root/.exegol/my-resources/setup/apt/packages.list
# The customization of some tools may require the installation of some packages or other dependencies.$
# To simplify this process, the name of the packages to be installed can be listed in this file.$
# All packages listed below will be installed automatically when creating a new Exegol container.$
eza$

Regards.

ThePorgs / Exegol-images