ThePorgs / Exegol

Fully featured and community-driven hacking environment
https://exegol.readthedocs.io/
GNU General Public License v3.0
1.95k stars 191 forks source link

Installed image are not correctly reported with podman #182

Open florentulve opened 1 year ago

florentulve commented 1 year ago

Describe the bug

The wrapper is able to download and installed an image correctly. However, further exegol install invocation does not report installed image.

After some debugging and step by step execution, i'v found that podman include the registry in the image tag, docker may not do it by default when docker.io registry is involved.

image

Steps To Reproduce

No response

Exegol Wrapper Version

Master branch 

5428a7a665cc386ac0d2d9296eb9ad07166920a2

Host OS

None

Configuration of the concerned container

No response

Execution logs in debug mode

![image](https://github.com/ThePorgs/Exegol/assets/2817358/aee5c1be-5d08-42d2-aed4-e6b4c92a21fa)

Exception

No response

Anything else?

No response

ShutdownRepo commented 1 year ago

Would you be able to do the change on your end and open a PR? As it is not our priority to support podman we won't spend time on it for the time being, but if there are pull requests that bring those changes we will be more than happy to review 🫡

florentulve commented 1 year ago

Ok, that's fair. I've made some other fixes to make things work. I'll open a pr when I will have enough time to to wrap it up.

ShutdownRepo commented 1 year ago

It'd be awesome! Thank you

xAiluros commented 12 months ago

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

florentulve commented 11 months ago

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

@xAiluros , made a small PR with the fixes I have done so far.

xAiluros commented 11 months ago

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

@xAiluros , made a small PR with the fixes I have done so far.

Thank you! Hope I can try it out soon and will try to see if I can improve anything