Closed ShutdownRepo closed 1 year ago
First issue, the autocomplete will not be able to dynamically list the profiles from a custom path as it won't be possible to obtain the --build-path
value live while writing the command.
Second, and this is a question, I'm wondering if it's better to either
as it won't be possible to obtain the --build-path value live while writing the command
Yes you can. In a custom completer, from the kargs argument you can get the current parameters and their value.
Imo, this option is very advance so no interactive option, only using CLI args.
If can update the completer for you, dont worry
The error displayed when trying to pass the dockerfile directly in the command line : But is ok interactively :
We can add the 'how to use' this feature in the doc on the contributor section
We can add the 'how to use' this feature in the doc on the contributor section
agreed, but before we add it in the doc, we should finalize the feature. As of now, the code is coded in the best way I knew how in a few minutes, but there's probably a better way to do it, and more logical/better workflow, that would affect the documentation
@Skileau You have the file custom.dockerfile
inside your dir Exegol-images
?
@Skileau You have the file
custom.dockerfile
inside your dirExegol-images
?
Yes it is in my dir Exegol-images and it is not present in the default exegol-docker-build.
@ShutdownRepo i can continue from here. Do we agree on removing the interactive section for the custom build path ? @Skileau i recreate your setup but i cannot reproduce your error..
@Skileau You have the file
custom.dockerfile
inside your dirExegol-images
?
The custom dockerfile is in his custom exegol images directory. The error is because the wrapper wants the profile arg to be in a list that's built from the regular images directory, instead of his custom one.
Yes nevermind if reproduced, fix incomming
@ShutdownRepo je viens de push les update, good pour moi, je te laisse regarder et tester @Skileau pareil, tu peux test à nouveau, dis moi si tu trouves des bugs
Adding the
--build-path
that a user can set for theexegol install
command for local builds to point to custom dockerfiles. This will be especially useful for external contributors that want to build a local image before creating a pull request on the images repo, without having to mess around with their official exegol install.Before this option, contributors would have to do something like
This would also allow contributors to have their own forks as well as their official exegol install without changes that they would be able to keep up to date (which wouldn't be possible if they were to change things locally without staging commits)