search

ThePoultryMan / Lanterns-Belong-On-Walls

A mod for Minecraft that allows placing lanterns on walls
MIT License
3 stars 1 forks source link

Incompatible with Secret Rooms #1

Closed SplendidAlakey closed 2 years ago

SplendidAlakey commented 2 years ago

MC 1.18.2 Fabric API 0.51.1 Secret Rooms 1.3.1 Lanterns 1.0.1

When both mods are installed together, the game crashes on startup: https://gist.github.com/Footage2-Amply-Pounce/f50b7fe9f28653957c57e7bce363c0a6

ThePoultryMan commented 2 years ago

The game was crashing due to the properties not being added in the appendProperties() method. I fixed this with a simple mixin into LanternButtonBlock. However, the models still need to be fixed. All these changes are being made on the bug/secretrooms branch.

ThePoultryMan commented 2 years ago

Update: These changes have been pushed to 1.18.x/dev, but I have discovered a new bug that I need to fix before I release another update.

Unrelated to the bug above: My current implantation requires the player to use a bundled resource pack that overrides the blockstate models from Secret Rooms. This causes the issue that players who don't enable the pack know which lanterns are the secret buttons. I'll play around to see if I can fix this, but it might be a permanent issue.

SplendidAlakey commented 2 years ago

Thanks for the update. The resource pack thing won't be an issue for me personally, I mostly play alone. But, of course, if you can fix it, that'd be great.

ThePoultryMan commented 2 years ago

The resource pack issue has been somewhat solved. If Secret Rooms is detected on launch, the resource pack will be forced on, but if it is not, then the resource pack will behave normally. I'm assuming that this detection is based on the order that mods are loaded, so if Lanterns Belong on Walls is loaded before Secret Rooms, then it won't work. Edit: In all of my testing, this doesn't happen. This might cause some issues, but it is likely a good enough solution.

The action build that contains these changes is here. Before I release another update, I'm going to see if I can fix #2.

Edit: The version number still hasn't been updated, but that doesn't really matter.