ThePoultryMan / Lanterns-Belong-On-Walls

A mod for Minecraft that allows placing lanterns on walls
MIT License
3 stars 1 forks source link

Generated lanterns have tendecy to spawn water-logged/ #12

Closed itsbanditodorito closed 1 year ago

itsbanditodorito commented 2 years ago

For some generated structures/features, such as supplementary's road signs/sign posts, lanterns that generate are water logged.

This can be reproduced by either generating a structure/feature that also generates lanterns using /place (non-vanilla command), or by using /setblock ~ ~ ~ minecraft:lantern. By using the latter, it will spawn a water logged lantern 100% of the time. Even if Lanterns Belong on Walls is the only mod present.

image image

Second image shows the lantern thinking its being placed on a wall, but there's no wall present. I'm guessing that would be why water spawns on it, so it was something to "place" on.

TelepathicGrunt commented 1 year ago

I keep getting reports from people about how lanterns in my structures from Repurposed Structures are spawning waterlogged since 1.18.2. I was never able to find what mod was at fault until just today when someone approached me in DM saying to might be this mod

Past issue reports: https://github.com/TelepathicGrunt/RepurposedStructures-Quilt/issues/219

The issue is this mixin is not safe (Pretty sure it's the default blockstate part): https://github.com/ThePoultryMan/Lanterns-Belong-On-Walls/blob/main/src/main/java/io/github/thepoultryman/walllanterns/mixin/WallLanternsMixin.java

Please switch to using Statement to properly adding new states to vanilla blocks without breaking other mods. They already handle all the strange edge cases and issues that comes with trying to hack in new states into vanilla blocks. https://www.curseforge.com/minecraft/mc-mods/statement

I'm going to have to mark this mod as incompatible with mine since it is causing lanterns to spawn waterlogged in my Nether Strongholds which is a big no as the Nether should never have water blocks. image

ThePoultryMan commented 1 year ago

This should no longer be an issue.