search

ThePoultryMan / Lanterns-Belong-On-Walls

A mod for Minecraft that allows placing lanterns on walls
MIT License
3 stars 1 forks source link

variant_lantern compat #8

Closed xanthian closed 2 years ago

xanthian commented 2 years ago

Includes Gold (Normal, Soul & Redstone) and Iron (Redstone variant) base lanterns. Includes all variants from 'Tech Reborn' pack

Havent tested with every lantern yet.

also build seems to be failing atm due to a 403 error on the modcompile of secret-rooms-fabric when trying to build, not related to this PR. I made another branch and removed the mixin, and secret-rooms stuff to test the build, all seems to be good. please dont accept this PR yet, as it is WIP and my mod is not released.

xanthian commented 2 years ago

tested with all lanterns in my mod, no issues ready for merge if you are happy to do so

ThePoultryMan commented 2 years ago

Sorry about this, but I have changed the placement system used. I forgot about the update I've had on the back burner. With these changes, the on_wall blockstate has been removed. This change also means that hanging now has to be false. Luckily, you should be able to do what I did and just find and replace within each file.

After these changes, I'm happy to merge.

xanthian commented 2 years ago

so
"hanging=true,on_wall=true,facing=north": { to "hanging=false,facing=north": { ?

ThePoultryMan commented 2 years ago

That is correct.

xanthian commented 2 years ago

added.

ThePoultryMan commented 2 years ago

I'm going to release this update tomorrow.