search

ThePrez / ServiceCommander-IBMi

Service Commander for IBM i
Apache License 2.0
40 stars 12 forks source link

Fix wrong logfile name #204

Closed chrjorgensen closed 1 year ago

chrjorgensen commented 1 year ago

Explain the reasoning for this pull request. For instance, is it for a new feature, bug fix, code style/cleanup, or something else? If fixing an open issue, please link to it here.

This PR will fix issue #203

Any additional comments/context?

ThePrez commented 1 year ago

Thanks for the discovery and PR! I haven't had time to "page into" this and re-examine the use of the timestamp formats, but would it be sufficient to keep only one (DB_TIMESTAMP_FORMAT) and just change it to the new value?

chrjorgensen commented 1 year ago

Unfortunately DB2 and Java use different symbols for the minutes and 24 hour, so one template can not be used for both timestamp formatters.

That's the reason for having two templates.

chrjorgensen commented 1 year ago

To expand on my previous comment, I also think that having two constants/templates demonstrates the difference between the timestamp formatters, so no one else will be caught by this.

ThePrez commented 1 year ago

@chrjorgensen just FYI this is still on my radar. I hope to review and get this landed later this week.

chrjorgensen commented 1 year ago

@ThePrez No worry - enjoy the Christmas break!