search

ThePrimeagen / harpoon

MIT License
6.35k stars 356 forks source link

Stopped working with git-worktree #551

Open wintermonth2298 opened 3 months ago

wintermonth2298 commented 3 months ago

Saves only files added from the project root. Even though the key is returned with the correct path (the path to the folder with the branch).

How to reproduce?

  1. Select a branch using git-worktree.
  2. Add an entry to harpoon.
  3. Close nvim
  4. Open nvim and select the desired branch using git-worktree

The recordings will not be saved.

The problem appeared after today's update

ThePrimeagen commented 3 months ago

When did you update? Can you make sure you pull one more time? I added some updates to make it so we save files continuously, not just on closing

wintermonth2298 commented 3 months ago

I'm on last commit 2e25a13. The previous update was a few days ago.

wintermonth2298 commented 3 months ago

You can test this behaviour by :lcd/cd to any dir in project and adding file to harpoon, then reopen nvim, :cd/lcd same dir and open harpoon.

ThePrimeagen commented 3 months ago

@wintermonth2298 there has been SEVERAL commits since a few days ago. you may want to update. there has been MANY of fixes. i am using harpoon wildly often

floork commented 3 months ago

Can confirm still not working (I am on the latest version)

kimabrandt-flx commented 3 months ago

I made an attempt of fixing this issue in #557. It'll break one of your testies, but maybe it can be helpful to solve this issue!?