search

ThePrimeagen / harpoon

MIT License
6.25k stars 348 forks source link

Fix1 #569

Closed ThePrimeagen closed 2 months ago

ThePrimeagen commented 2 months ago

@sug44 here you go

ThePrimeagen commented 2 months ago

a couple of breaking tests... looking

ThePrimeagen commented 2 months ago

@sug44 removing exact path has caused bugs

sug44 commented 2 months ago

the tests were breaking on the parent commit as well, so i didnt try to fix any of them

ThePrimeagen commented 2 months ago

yeah, but the removal has caused somethings

there is also the usage of realpath that is causing breaking

ThePrimeagen commented 2 months ago

also... i realized... i cannot have this change

i am going to have to think of something different.

this change breaks one of the core concepts of harpoon. i can have 2 repos, both with the same key() in settings (think workspaces) and it will return the same results. i must have relative paths