ThePrimeagen / neovimrc

366 stars 34 forks source link

local_plugins obviously not there when just pulling, intended? #3

Open FPVogel opened 9 months ago

FPVogel commented 9 months ago

Hey, I've just been trying out this nvim config and noticed that when just dropping it in (pulling and moving to my .config/nvim) everything seems to be working fine except for the harpoon import, which is seemingly (after two minutes of looking) being imported through lua/theprimeagen/lazy/local.lua from ~/personal/harpoon, which also seemingly corresponds to the private personal submodule in your dotfiles repo.

Is this intended behaviour to run a local dev-version of harpoon (or whatever) or is it just set up this way for no particular reason relevant to its inclusion on github? I've now fixed this locally for me (to use lazy instead) and I'd be willing to create a PR to push the changes I made to this repo.

Just let me know if the PR would be appreciated, all the best :)

ltsuda commented 9 months ago

Hello, as this is his nvim configuration, using this entire repo as your configuration might not be a good idea for long term usage but to try it on and make your own customization.

Also, his configuration might not be in a "final" state for the beginning of 2024 yet because the video is not ready yet or he will change something before posting the video, I guess.

Regarding the local configuration, loading his local harpoon is probably intended as he uses daily and in case he finds something to improve or a bug, then he can change some code, load nvim/harpoon from his local repo, test and then push to harpoon repo. That's my guess too.

tabedzki commented 6 months ago

@FPVogel see my comment in #5 about how to get harpoon working without modifying the referenced directory.

ThePrimeagen commented 6 months ago

I need to update the readme this is not my repo anymore. I'm going to update the readme shortly with the new link

ThePrimeagen/dev