Closed Vikasg7 closed 1 year ago
@vhladko how can I add my changes to the repo now as now I have been added to the CODEOWNER file?
As your changes target your own repo, don’t you have merge button ? If not, we will discuss it with Prime, cause I’m not aware of codeowners merge strategy :)
I am seeing no merge buttons yet.
And can you approve this PR ?
Sorry, but I am not seeing no approve PR button on my screen.
Approve button should be when you switch to the Files changed tab and there should be green button on the right Review or something like that, and when you click - approve should be there :)
Here is what I am seeing. still can't approve.
I see, okay, then looks like you can approve someone else PR to your folder but can’t approve your :) I’ll talk with Prime, but it looks like you just tag one of maintenance when it’s ready and we merge :)
@Vikasg7 do we need to keep this open ? :)
@vhladko You can merge it for now. thanks.
Nice, thank you ! :)
This PR exists only for the purpose for push my change to the ThePrimeagen/ts-rust-zig-deez repository. Everyone else you want to contribute can submit PR to my fork here so that we don't clutter PRs in ThePrimeagen repo.