ThePrimeagen / ts-rust-zig-deez

627 stars 162 forks source link

[JJDSL] : Feat - Completed Chapter One #163

Closed Crain-32 closed 1 year ago

Crain-32 commented 1 year ago

Tom wishes I was his mentor.

Utilizes the Battle Tested Enterprise Standard Java 8. Along with the well documented Nashorn Javascript runtime bundled into the JVM.

The no-nonsense ECMAScript 5.1 standard allows us to be incredibly clear with our definitions.

Shoutout to @trvswgnr who's Javascript Solution I referenced heavily in the creation of this.

Funnily enough after you get the build system working, it's not... the worst? Still better than CMake.

Crain-32 commented 1 year ago

Build will likely continue to fail. By default it pulls from Prime's Master branch, but obviously the defaults don't exist on there yet.

In other words, you have to merge it to know it works in the CI/CD Pipeline, the best type of Situation.

vhladko commented 1 year ago

Add yourself as a Codeowner pls :)

Crain-32 commented 1 year ago

@vhladko do I do that on this branch, or another branch?

vhladko commented 1 year ago

You can do this in current PR :)

vhladko commented 1 year ago

Nice, merged :)