search

ThePrimeagen / ts-rust-zig-deez

610 stars 163 forks source link

Kotlin: Refactored and extended lexing #182

Closed ekgame closed 1 year ago

ekgame commented 1 year ago

This change refactors the lexer to use a single data class and a type enum for all tokens. The tokens now also keep track of their position in the document - will be useful in the future to give useful errors while parsing/evaluating and opens a possibility for an LSP.

The web platform REPL has also been replaced with a debug console - a Monaco editor with a real-time updating lexer output.

https://github.com/ThePrimeagen/ts-rust-zig-deez/assets/1730245/e9b737ed-d2f2-4d55-b1ab-a5fca1a91d8b

The JVM REPL has no changes, still just a boring console output.

vhladko commented 1 year ago

@hermannm could you take a look since you are co-owner :)

vhladko commented 1 year ago

@hermannm does your like icon means that it could be merged or that you will take a look at it ? :)

hermannm commented 1 year ago

@hermannm does your like icon means that it could be merged or that you will take a look at it ? :)

That I'm taking a look at it! But it's a lot of changes, and I'm kinda busy this week - I've asked @LizAinslie to review

vhladko commented 1 year ago

Thanks ! Just to clarify :) For some reason couldn't find @LizAinslie with autocomplete to also ask for review :)

LizAinslie commented 1 year ago

LGTM

vhladko commented 1 year ago

nice, thanks :)