Closed codebrainz closed 1 year ago
@nicdgonzalez can you take a look ? :)
@codebrainz I haven't had the chance to create a new PR with my most recent changes but I did end up following through with this suggestion and using std::string_view
and std::move
ing it into input_
.
I apologize for not replying to this a week ago, but I do appreciate you taking the time to review and leave a suggestion. I did my research on string_view
and move
and ended up learning something new so, truly, thank you. 👍
@vhladko Changes have been approved.
Thank you for always taking the time to notify me on these pull requests. :)
As mentioned in this comment.