search

ThePrimeagen / ts-rust-zig-deez

610 stars 163 forks source link

cpp: Use string_view to avoid 2 unnecessary copies of input. #205

Closed codebrainz closed 1 year ago

codebrainz commented 1 year ago

As mentioned in this comment.

vhladko commented 1 year ago

@nicdgonzalez can you take a look ? :)

nicdgonzalez commented 1 year ago

@codebrainz I haven't had the chance to create a new PR with my most recent changes but I did end up following through with this suggestion and using std::string_view and std::moveing it into input_.

I apologize for not replying to this a week ago, but I do appreciate you taking the time to review and leave a suggestion. I did my research on string_view and move and ended up learning something new so, truly, thank you. 👍

nicdgonzalez commented 1 year ago

@vhladko Changes have been approved.

Thank you for always taking the time to notify me on these pull requests. :)