search

ThePrimeagen / ts-rust-zig-deez

610 stars 163 forks source link

feat(java): Implementing up to chapter 2.5: The basic parser structure #211

Closed RafRunner closed 1 year ago

RafRunner commented 1 year ago

This is just a rough implementation where I tried to stay pretty close to the book. I don't really like how I did many things, especially overwriting the toString() method to represent Nodes as strings and abstract classes and multiple inheritance, but I just wanted to throw a quick implementation and take some suggestions.

We can't forget the real complicated part is still ahead so we shouldn't implement some super fancy thing that will make things a lot harder later.

vhladko commented 1 year ago

@xNaCly @Crain-32 what do you guys think ? :)

Crain-32 commented 1 year ago

Apologizes for the Lack of a Response. Github didn't ping my email for one, and I've also been sick the past 2 days.

RafRunner commented 1 year ago

Addressed all points @Crain-32. Please mark all you fell have been addressed properly as resolved or comment further.

RafRunner commented 1 year ago

You have a lot of Public Properties in Classes, please swap those to private /w Getters.

I keept it that way to keep to code more boilerplate free, as if the classes were records, because I don't believe we'll ever need extra code when getting or settings values, but I'll change it since it is the java way after all

vhladko commented 1 year ago

Nice, let's go :)