search

ThePrimeagen / ts-rust-zig-deez

610 stars 163 forks source link

[csharp] Added readme and comments to chapter 1 #215

Closed TomasDurica closed 1 year ago

TomasDurica commented 1 year ago

I really loved TJs approach to OCaml - adding comments to explain the language idioms. I am trying to achieve the same thing with this - especially because I am using some new or not well-known features (you would be surprised how many seasoned senior devs (and good devs) do not know about list patterns - it is just not something that come up that often in real world)

vhladko commented 1 year ago

@MarioGK what do you think ? :)

TomasDurica commented 1 year ago

@vhladko Unfortunately, last time @MarioGK didn't have too much time: image (you can see in my first closed PR), but I have no issues to wait - maybe his situation changed :)

vhladko commented 1 year ago

Oh, sorry, I forgot about that, then go merge :)

MarioGK commented 1 year ago

@TomasDurica @vhladko Thanks for asking my opinion, but you guys can take over the csharp implementation, i am really busy these days and i will not be able to contribute much

TomasDurica commented 1 year ago

@vhladko no worries mate - I see you are active in a lot of PRs - doing a hell of a good job and helping Prime - no one is expecting you to remember all the stuff :) @MarioGK - I know but I still would like to keep your name in the codeowners, as you were the first :) But if you don't want, just let me know - I don't want to unnecessarily bother you if you don't want - I know fame can be difficult :)