search

ThePrimeagen / ts-rust-zig-deez

627 stars 162 forks source link

Using an External Repo for JJDSL #222

Closed Crain-32 closed 1 year ago

Crain-32 commented 1 year ago

@novusnota , I'd assume this falls more into your ballpark. But right now I have ts-rust-zig-deez master set as the default Repository that JJDSL pulls the files from. However this causes some problems.

  1. If any changes to the commit tree happens that impacts a reference Commit, JJDSL will break.

  2. Cloning a Git Repo brings in all the files. The current "build" phase of JJDSL is to clone the repo, jump around the commits in Master, extract a file, and eventually delete the repository. I was thinking it would be fine, as the overall size of the Repository is current 6mb. But I'm also not sure if the eventual Packages will have the ability to manage two repositories (Likely being paranoid here.

Would I be able to host the "source code" repository for JJDSL on a repository on my own Account? So it would pull from https://github.com/Crain-32/JJDSL-Source.git on master, instead of https://github.com/ThePrimeagen/ts-rust-zig-deez. I'm mostly concerned about any commit changes impacting it.

Crain-32 commented 1 year ago

@ThePrimeagen I suppose you would also be a decent ping for this. Any thoughts?

novusnota commented 1 year ago

@Crain-32 Hey, I don't think one should meddle with git history of this repo. And so yeah, host source in your account and clone/pull/whatever in your JJDSL-related MonkeyLang interpreter code here

Crain-32 commented 1 year ago

Going to move forward with novusnota's comment and do the JJDSL reference code on my own repository, I'll stick it in a JJDSL readme.