search

ThePrimeagen / ts-rust-zig-deez

606 stars 160 forks source link

C#: Changed implementation to use reader instead of position counting… #238

Closed TomasDurica closed 1 year ago

TomasDurica commented 1 year ago

… and added comments for educational purposes

TomasDurica commented 1 year ago

@leo-costa - would it be too bold of me to snag your docker and makefile? Just so I will not have failing checks :)

TomasDurica commented 1 year ago

@vhladko - don't want to bother you, but can you take a look when you will have time? :) Also, would you prefer to always tag you, or should I just wait :)

leo-costa commented 1 year ago

@leo-costa - would it be too bold of me to snag your docker and makefile? Just so I will not have failing checks :)

Go ahead! I'm using dotnet 8 tho!

TomasDurica commented 1 year ago

@leo-costa - many thanks :) Yes I will make sure it works, I just wanted a start point and I always feel bad when I just blatantly steal stuff :D

leo-costa commented 1 year ago

@leo-costa - many thanks :) Yes I will make sure it works, I just wanted a start point and I always feel bad when I just blatantly steal stuff :D

I know you mentioned your solution doesn't really care much for speed but for what it is worth, dotnet 8 was about 23% faster than 7 on synthetic benchmarks on csharp2 folder.

TomasDurica commented 1 year ago

@leo-costa Cool - I will definitely try it. The performance went out the window the second I started boxing structs :D I wanted to not be left in the dust, but the list patterns looked much more fun than squeezing every bit from the performance - so I just left all restraints behind me and went full dive into it (I still am trying to not do obvious mistakes - but sometimes I can't help myself :D )