search

ThePrimeagen / ts-rust-zig-deez

605 stars 160 forks source link

feat(java): Continuing parser development up to chapter 2.6 (Infix Expressions) #243

Closed RafRunner closed 10 months ago

RafRunner commented 1 year ago

Implementing up to chapter 2.6 of the book and keeping pretty close to it. I posed some questions on the forms of TODOS that will need to be resolved before the merge, or we can change it later. I tried to keep everything simple and follow conventions, and I'm open for suggestions. We should just try and keep things close to the book at least until the whole parser is finished.

RafRunner commented 1 year ago

I'll fix the broken checks later (+-8hrs)

RafRunner commented 1 year ago

This took a little longer than expected, but I added a Makefile and removed the cache part of the Dockerfile since in order for that to work we would need to modify the static part of the Makefile which I don't think Prime wants us to do.

Crain-32 commented 1 year ago

I'll review this tomorrow.

RafRunner commented 1 year ago

I just realized the check got stuck because the docker image executes main and it gets stuck waiting input.

I believe it should just run the tests.

Can't change and test it right now, I'll address it later .

Crain-32 commented 1 year ago

@vhladko Just wanted to bump the PR and remind you it's good to merge.

RafRunner commented 11 months ago

If anyone still cares, I finished the book and merged into this PR's branch so the Java implementation would be complete.